lfg2025/archy
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases 33 Wiki Activity

fix: audit and harden deploy script reliability

Browse Source 
- Add pipefail to catch pipe errors (set -eo pipefail)
- Fix duplicate NEED_INSTALL="" initialization
- Fail on missing binary in --both path (was silently ignored)
- Add post-deploy health check on .198 (polls 60s)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Dorian
2026-03-14 03:04:08 +00:00
parent 55deb69175
commit 2becf9391a
2 changed files with 21 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
loop/plan.md
View File

@@ -291,7 +291,7 @@ Every test must pass **10 consecutive times** from BOTH .228→.198 AND .198→.
### Sprint 12: Deploy Script Hardening
- [ ] **DEPLOY-01** — Audit deploy-to-target.sh for reliability. Read the entire script. Check: error handling (set -e?), rollback on failure, health check after deploy, idempotency, atomic swaps for binary and frontend. Fix any issues. **Acceptance**: Deploy script has proper error handling, health verification, and rollback capability.
- [x] **DEPLOY-01** — Audited deploy-to-target.sh. Fixes: (1) `set -eo pipefail` for pipe error detection. (2) Fixed duplicate `NEED_INSTALL=""`. (3) --both path now fails on missing binary instead of `|| true`. (4) Added post-deploy health check on .198 (polls every 5s for 60s). Rollback is deferred to DEPLOY-03.
- [ ] **DEPLOY-02** — Add canary deploy mode. Deploy to .198 first, run health checks, then deploy to .228. If .198 health fails, abort before touching .228. Add `--canary` flag to deploy script. **Acceptance**: `./scripts/deploy-to-target.sh --canary` deploys to .198, verifies, then .228.