From e4d0eca910a0d05297d3ca3f7435883447e9cd60 Mon Sep 17 00:00:00 2001 From: Dorian Date: Wed, 11 Mar 2026 17:47:53 +0000 Subject: [PATCH] refactor: remove dead code, complete quality sweep (FINAL-03) - Remove unused _restartApp in Apps.vue - Remove unused version computed in Home.vue - Remove unused filteredCommunityApps in Marketplace.vue - All metrics clean: 0 type errors, 0 build warnings, 515/515 tests pass Co-Authored-By: Claude Opus 4.6 --- loop/plan.md | 2 +- neode-ui/src/views/Apps.vue | 10 ---------- neode-ui/src/views/Home.vue | 3 --- neode-ui/src/views/Marketplace.vue | 6 ------ 4 files changed, 1 insertion(+), 20 deletions(-) diff --git a/loop/plan.md b/loop/plan.md index f7a55bc2..1274e0a1 100644 --- a/loop/plan.md +++ b/loop/plan.md @@ -400,7 +400,7 @@ - [x] **FINAL-02** — Run final security audit. Complete security review of: all 80+ RPC endpoints, nginx configuration, container isolation, secrets management, session handling. Fix any findings. **Acceptance**: Zero critical/high findings. -- [ ] **FINAL-03** — Run final sweep. Execute `/sweep`. All metrics must be at zero violations or documented exceptions. **Acceptance**: Sweep report clean. +- [x] **FINAL-03** — Run final sweep. Execute `/sweep`. All metrics must be at zero violations or documented exceptions. **Acceptance**: Sweep report clean. - [x] **FINAL-04** — Performance benchmark and optimize. Benchmark: page load time (<2s on LAN), RPC response time (<100ms for reads, <500ms for writes), container install time (<60s for cached images). Optimize any failures. **Acceptance**: All benchmarks met. diff --git a/neode-ui/src/views/Apps.vue b/neode-ui/src/views/Apps.vue index e3ce06ce..177ff631 100644 --- a/neode-ui/src/views/Apps.vue +++ b/neode-ui/src/views/Apps.vue @@ -416,16 +416,6 @@ onBeforeUnmount(() => { actionTimers.clear() }) -// @ts-ignore - Function kept for future use -// eslint-disable-next-line @typescript-eslint/no-unused-vars -// eslint-disable-next-line @typescript-eslint/no-unused-vars -async function _restartApp(_id: string) { - try { - await store.restartPackage(_id) - } catch (err) { - if (import.meta.env.DEV) console.error('Failed to restart app:', err) - } -} function showUninstallModal(id: string, pkg: PackageDataEntry) { uninstallModal.value = { diff --git a/neode-ui/src/views/Home.vue b/neode-ui/src/views/Home.vue index acb6857a..064dbe75 100644 --- a/neode-ui/src/views/Home.vue +++ b/neode-ui/src/views/Home.vue @@ -470,9 +470,6 @@ watch(() => loginTransition.startWelcomeTyping, (shouldStart) => { }, MS_PER_CHAR) }, { immediate: true }) -// @ts-ignore - Computed kept for future use -// eslint-disable-next-line @typescript-eslint/no-unused-vars -const version = computed(() => store.serverInfo?.version || '0.0.0') const packages = computed(() => store.packages) const appCount = computed(() => Object.keys(packages.value).length) const runningCount = computed(() => diff --git a/neode-ui/src/views/Marketplace.vue b/neode-ui/src/views/Marketplace.vue index 621094b1..938a1e83 100644 --- a/neode-ui/src/views/Marketplace.vue +++ b/neode-ui/src/views/Marketplace.vue @@ -638,12 +638,6 @@ const filteredApps = computed(() => { return apps }) -// Keep for backward compatibility -// @ts-ignore - Computed kept for backward compatibility -// eslint-disable-next-line @typescript-eslint/no-unused-vars -const filteredCommunityApps = computed(() => { - return communityApps.value -}) /** Marketplace app ID -> backend package keys (for "Already Installed" when first-boot/deploy created them) */ const INSTALLED_ALIASES: Record = {