lfg2025/archy
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases 33 Wiki Activity

fix: protocol-aware iframe vs new-tab behavior for all apps

Browse Source 
Apps with absolute-path redirects (Jellyfin, Portainer, PhotoPrism,
OnlyOffice, Uptime Kuma, Fedimint) now correctly open in new tab on
HTTPS where subpath proxy breaks their redirects, but still use iframe
on HTTP where direct port access works fine.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Dorian
2026-03-09 00:22:41 +00:00
parent c45de13752
commit b581fb4126
2 changed files with 25 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
loop/plan.md
View File

@@ -13,7 +13,7 @@
- [x] **APP-101** — fix(marketplace): audit and fix all 24 marketplace app install flows. For each app in `getCuratedAppList()` in `neode-ui/src/views/Marketplace.vue` (bitcoin-knots, electrs, btcpay-server, lnd, mempool, homeassistant, grafana, searxng, ollama, onlyoffice, penpot, nextcloud, vaultwarden, jellyfin, photoprism, immich, filebrowser, nginx-proxy-manager, portainer, uptime-kuma, tailscale, fedimint, indeedhub), verify each one: (1) marketplace card renders correctly with icon, (2) clicking Install triggers `package.install` RPC, (3) container pulls and creates successfully, (4) container starts on the correct ports per `apps/PORTS.md`, (5) status shows "Running" in My Apps. Fix any broken apps. Deploy with `./scripts/deploy-to-target.sh --live`. Test each app at http://192.168.1.228.
- [ ] **APP-102** — fix(apps): ensure iframe vs new-tab behavior is correct for all apps. In `neode-ui/src/stores/appLauncher.ts`, verify `mustOpenInNewTab()` includes all apps that set `X-Frame-Options: DENY/SAMEORIGIN`. Currently covers BTCPay (23000), Home Assistant (8123), Nextcloud (8085), Immich (2283). Test each running app by clicking "Open" in AppDetails.vue — iframe apps must load inside the overlay, new-tab apps must open in a fresh browser tab. If any app fails to load in iframe, either fix the nginx proxy to strip X-Frame-Options or add it to `mustOpenInNewTab()`. Deploy and verify each app.
- [x] **APP-102** — fix(apps): ensure iframe vs new-tab behavior is correct for all apps. In `neode-ui/src/stores/appLauncher.ts`, verify `mustOpenInNewTab()` includes all apps that set `X-Frame-Options: DENY/SAMEORIGIN`. Currently covers BTCPay (23000), Home Assistant (8123), Nextcloud (8085), Immich (2283). Test each running app by clicking "Open" in AppDetails.vue — iframe apps must load inside the overlay, new-tab apps must open in a fresh browser tab. If any app fails to load in iframe, either fix the nginx proxy to strip X-Frame-Options or add it to `mustOpenInNewTab()`. Deploy and verify each app.
- [ ] **APP-103** — fix(apps): verify all PORT_TO_PROXY mappings in appLauncher.ts match nginx config. Cross-reference every entry in `PORT_TO_PROXY` in `neode-ui/src/stores/appLauncher.ts` with the actual nginx location blocks in `image-recipe/configs/nginx-archipelago.conf` and `image-recipe/configs/snippets/archipelago-https-app-proxies.conf`. Any missing nginx proxy blocks must be added. Any port mismatches must be corrected. Deploy nginx config and verify each app loads via its proxy path.

29
neode-ui/src/stores/appLauncher.ts
View File

@@ -1,16 +1,35 @@
import { defineStore } from 'pinia'
import { ref } from 'vue'
/** Apps that set X-Frame-Options and/or don't support subpath proxy - open in new tab for correct display */
/** Apps that must open in new tab instead of iframe.
* - DENY apps: always new tab (X-Frame-Options: DENY)
* - Redirect apps: new tab on HTTPS (absolute redirects break subpath proxy in iframe)
* On HTTP, these load via direct port URL so iframe works fine.
*/
function mustOpenInNewTab(url: string): boolean {
try {
const u = new URL(url)
return (
u.port === '23000' || // BTCPay
u.port === '8123' || // Home Assistant
// Always new tab: X-Frame-Options DENY or subpath fundamentally breaks the app
if (
u.port === '23000' || // BTCPay (X-Frame-Options: DENY)
u.port === '8123' || // Home Assistant (subpath breaks routing)
u.port === '8085' || // Nextcloud (subpath breaks CSS/assets)
u.port === '2283' // Immich (subpath breaks SPA)
)
) {
return true
}
// On HTTPS, apps with absolute-path redirects break in iframe via proxy
if (window.location.protocol === 'https:') {
return (
u.port === '8096' || // Jellyfin (redirects to /web/index.html)
u.port === '9000' || // Portainer (redirects to /timeout.html)
u.port === '2342' || // PhotoPrism (redirects to /library/login)
u.port === '9980' || // OnlyOffice (redirects to /welcome/)
u.port === '3001' || // Uptime Kuma (redirects to /dashboard)
u.port === '8175' // Fedimint (redirects to /login)
)
}
return false
} catch {
return false
}